https://kedro.org/ logo
Powered by
#questions
Title
# questions
s

Simen Husøy

01/18/2023, 3:11 PM
Hi, after upgrading to kedro-viz 5.2.0 i get the following error:
Copy code
kedro.framework.cli.utils.KedroCliError: not enough values to unpack (expected 3, got 1)
Run with --verbose to see the full exception
Error: not enough values to unpack (expected 3, got 1)
Worked with the previous version, anyone knows why this happens? (full stack trace in comments)
d

datajoely

01/18/2023, 3:12 PM
can you run with verbose option?
s

Simen Husøy

01/18/2023, 3:16 PM
How do I run it in verbose mode? Have looked in both 
kedro viz
and 
kedros
help page and it doesn't say anything about the 
--verbose
flag. (I also tried, but said "no such option")
d

datajoely

01/18/2023, 3:16 PM
kedro viz --verbose
s

Simen Husøy

01/18/2023, 3:18 PM
Something must be very wrong here:
d

datajoely

01/18/2023, 3:18 PM
weird!
does a normal 
kedro run
work?
s

Simen Husøy

01/18/2023, 3:18 PM
Yup
a

Antony Milne

01/18/2023, 3:19 PM
Uhoh, I think I know what will have caused this… @Merel https://github.com/kedro-org/kedro-viz/pull/1214 something like this: 
_, dataset_type, dataset_file = "a.b".split(".")
😬 1
@Tynan if you were about to do a release announcement, I’d hold off for a second since I think this might need a quick patch fix.
t

Tynan

01/18/2023, 3:20 PM
ok
a

Antony Milne

01/18/2023, 3:21 PM
@Simen Husøy in your data catalog, do you have any entries that specify 
type
as something a bit weird? Like custom dataset types?
s

Simen Husøy

01/18/2023, 3:22 PM
Yep! Can send you a screenshot
Copy code
radar_data:
  type: birdslib.common.kedro_datasets.falcon_dataset.Falcon_radar_dataset

falcon_test_data:
  type: birdslib.common.kedro_datasets.falcon_dataset.Falcon_test_dataset
  args:
    amount: 2

cross_section_plot:
  type: matplotlib.MatplotlibWriter
  filepath: data/08_reporting/cross_section_plot.png
  save_args:
    format: png

cross_section_plot_plotly:
  type: plotly.JSONDataSet
  filepath: data/08_reporting/cross_section_plot_plotly.json
  layer: reporting
  versioned: true
This is my data_catalog
So two custom dataset classes
a

Antony Milne

01/18/2023, 3:25 PM
Hmmm, just to test: please could you comment out those datasets?
s

Simen Husøy

01/18/2023, 3:25 PM
When running kedro viz, or kedro run?
a

Antony Milne

01/18/2023, 3:26 PM
kedro viz
s

Simen Husøy

01/18/2023, 3:27 PM
Tried to comment out the custom ones, and then the plotting ones as well. Gave equal results
a

Antony Milne

01/18/2023, 3:29 PM
Weird… I’m not immediately sure but we should definitely try and fix that 😬 For the time being if you want to try out the plotly image datasets then I’d just use kedro 0.18.3 + kedro-viz 5.1.1 and I think all should work well.
@Jannic Holzer @Rashida Kanchwala can you see why this isn’t working? At a glance I’m 95% sure it’s that PR I linked to above.
s

Simen Husøy

01/18/2023, 3:29 PM
Yeah, got that working earlier today, so thats nice!
m

Merel

01/18/2023, 3:35 PM
Yeah it’s probably the bit where we parse the module and class. Strange viz still doesn’t work when commenting those datasets out though..
j

Jannic Holzer

01/18/2023, 3:52 PM
Taking a look into this now
👍 2
t

Tynan

01/19/2023, 9:39 AM
@Jannic Holzer any update on this?
r

Rashida Kanchwala

01/19/2023, 9:59 AM
i faced this issue while writing the tests. it's to do with how dataset. _ class _. _module _ is handled differently for AbstractDataSet and AbstractVersionedDataSet but I am not sure how to solve this as it's framework side issue
j

Jannic Holzer

01/19/2023, 10:04 AM
Still looking into it, it's either (or both) 
_get_dataset_type
(
flowchart.py
) or 
get_dataset_type
(
experiment_tracking.py
) that's causing the issue
👍 1
t

Tynan

01/20/2023, 3:17 PM
@Simen Husøy what's your GitHub username?
j

Jannic Holzer

01/25/2023, 12:47 PM
Hey @Simen Husøy, we've worked on a potential fix for this problem, though we haven't been able to replicate your error. Could I give you a 
.whl
file of a modified 
5.2.0
release for you to test and see if it resolves your error?
s

Simen Husøy

01/25/2023, 2:30 PM
Yes, I can see if it solves the problem. Don't know if I'll be able to do it this week, but should be possible next week
👍 2
j

Jannic Holzer

01/25/2023, 3:04 PM
Great, thank you 🙂 I'll prepare the file
a

Antony Milne

01/25/2023, 3:04 PM
One quick check @Simen Husøy: do you use transcoding in your project? i.e. are there entries with 
@
in the dataset name in the catalog?
👍 1
s

Simen Husøy

01/26/2023, 2:27 PM
No, I don't think so
j

Jannic Holzer

01/30/2023, 9:16 AM
@Simen Husøy we released a patch version (5.2.1) to PyPI which could solve your issue, feel free to try and upgrade again.
😍 2
👍 1
s

Simen Husøy

01/30/2023, 12:10 PM
Cool, I'll try it out within the week
Powered by