Hi folks I'm trying to create a custom kedro dataset (inherited from AbstractVersionedDataSet) I have to write a few tests similar to the ones existing for CsvDataSet However I'm witnessing that a few tests are failing. Need some advice around the same. happy to hop on a call to discuss the details

hi @Pranav Khurana! what version of

kedro

and

kedro-datasets

are you using, and what tests are failing?

kedro version

0.18.8

that code is part of https://github.com/kedro-org/kedro/blob/c48a8469b0fda3a39690c58de95b9f90165a0bc6/kedro/io/core.py#L628-L639 are you inheriting from

AbstractVersionedDataSet

, like

pandas.CSVDataSet

is? https://github.com/kedro-org/kedro-plugins/blob/031b737337ac2023e29009142a156d1f8969a31e/kedro-datasets/kedro_datasets/pandas/csv_dataset.py#LL[…]42

Yes I'm inheriting from AbstractVersionedDataset

how does your

_save

method look like?

Precisely Juan Both the functions you mentioned, raise error for different reasons, for the path being invalid and for overwriting an already existing dataset with a new one

Maybe there’s something missing in my code

looks like it. for example, passing an invalid path would fail in the

get_protocol_and_path

function that CSVDataSet uses: https://github.com/kedro-org/kedro-plugins/blob/031b737337ac2023e29009142a156d1f8969a31e/kedro-datasets/kedro_datasets/pandas/csv_dataset.py#L112 unfortunately creating a dataset currently requires some copy-pasting https://github.com/kedro-org/kedro/issues/1936#issuecomment-1597474696

I figured it out!

🙌🏼 any time @Pranav Khurana! happy that you got it solved

Could you also please explain just one more functionality to me ?