Pranav Khurana
06/20/2023, 11:32 AMJuan Luis
06/20/2023, 11:32 AMkedro
and kedro-datasets
are you using, and what tests are failing?Pranav Khurana
06/20/2023, 11:34 AM0.18.8
test_versioning_existing_dataset
Juan Luis
06/20/2023, 11:48 AMAbstractVersionedDataSet
, like pandas.CSVDataSet
is?
https://github.com/kedro-org/kedro-plugins/blob/031b737337ac2023e29009142a156d1f8969a31e/kedro-datasets/kedro_datasets/pandas/csv_dataset.py#LL[…]42Pranav Khurana
06/20/2023, 11:52 AMJuan Luis
06/20/2023, 11:55 AM_save
method look like?Pranav Khurana
06/20/2023, 5:35 PMJuan Luis
06/20/2023, 9:32 PMMaybe there’s something missing in my codelooks like it. for example, passing an invalid path would fail in the
get_protocol_and_path
function that CSVDataSet uses:
https://github.com/kedro-org/kedro-plugins/blob/031b737337ac2023e29009142a156d1f8969a31e/kedro-datasets/kedro_datasets/pandas/csv_dataset.py#L112
unfortunately creating a dataset currently requires some copy-pasting https://github.com/kedro-org/kedro/issues/1936#issuecomment-1597474696Pranav Khurana
06/21/2023, 7:49 AMJuan Luis
06/21/2023, 7:51 AMPranav Khurana
06/21/2023, 12:30 PMtest_catalog_release
function