Hi has anyone found any issues when using OmegaCon...
# questionsa
Artur Dobrogowski
05/30/2023, 8:15 AMHi has anyone found any issues when using OmegaConfigLoader from new kedro version? For me when I enabled it and made used env templating in file, the config Validator started raising issues for correct lists in yaml, error looks like this:
Copy code
ValidationError: 1 validation error for KedroMlflowConfig
tracking -> disable_tracking -> pipelines
value is not a valid list (type=type_error.list) Copy code
tracking:
disable_tracking:
pipelines: []j
Juan Luis
05/30/2023, 8:36 AMhi @Artur Dobrogowski, thanks for trying it out and sorry you had a rough experience!
my hunch is that the list must not be empty? https://github.com/Galileo-Galilei/kedro-mlflow/blob/845ad919c9dbd020e948e8adc2e0f9064de1ef68/kedro_mlflow/config/kedro_mlflow_config.py#L48-L50 but I'm not completely sure.
cc @Yolan Honoré-Rougé
a
Artur Dobrogowski
05/30/2023, 8:36 AMtried with non empty as well
j
Juan Luis
05/30/2023, 8:37 AMmaybe there's some transformation on the fly happening. your question on how to debug this https://kedro-org.slack.com/archives/C03RKP2LW64/p1685435091328909 is a good one. do you have a more complete traceback?
a
Artur Dobrogowski
05/30/2023, 8:38 AMUntitled
Artur Dobrogowski
05/30/2023, 8:38 AMYeah I have traceback but didnt want to spam here with it.
Artur Dobrogowski
05/30/2023, 8:46 AMThe issue arises when I use omegaconfigloader, with other loaders the config is fine, so it looks like a bug to me
j
Juan Luis
05/30/2023, 8:46 AMI can reproduce:
Juan Luis
05/30/2023, 8:48 AM Copy code
from kedro.config import OmegaConfigLoader
from kedro.config import ConfigLoader
from kedro_mlflow.config.kedro_mlflow_config import KedroMlflowConfig
loader = OmegaConfigLoader(".", config_patterns={"conf": ["conf*"]})
loader_ok = ConfigLoader(".", config_patterns={"conf": ["conf*"]})
KedroMlflowConfig.parse_obj({**loader.get("conf")})
KedroMlflowConfig.parse_obj({**loader_ok.get("conf.yml")}) Copy code
$ tree .
.
├── base
│ └── conf.yml
├── local
$ cat base/conf.yml
tracking:
disable_tracking:
pipelines: []maina
Artur Dobrogowski
05/30/2023, 8:51 AMGlad that it's easily reproducible
j
Juan Luis
05/30/2023, 8:53 AMthe reason is this:
Copy code
In [2]: conf_bad = loader.get("conf")
In [3]: conf_bad
Out[3]: {'tracking': {'disable_tracking': {'pipelines': []}}}
In [4]: type(conf_bad)
Out[4]: omegaconf.dictconfig.DictConfigmainJuan Luis
05/30/2023, 8:54 AMwith
main👍 1
a
Artur Dobrogowski
05/30/2023, 8:54 AMok great
Artur Dobrogowski
05/30/2023, 9:00 AMThanks a lot for the help
j
Juan Luis
05/30/2023, 9:22 AMany time @Artur Dobrogowski 🙌🏼 stay tuned to #general for the upcoming release
16 Views