Hi guys! I've been thinking of contributing to ked...
# plugins-integrations
w
Hi guys! I've been thinking of contributing to kedro-datasets , but havent found a specific contributing guidelines. Should I follow the extras guidelines? (lint, convention,etc..)
d
Yes, that would be great! It's a good note that those guidelines are missing.
w
@Deepyaman Datta Should I copy the instructions/makefiles to kedro-plugins as well?
@Deepyaman Datta other side note, using the makefile from kedro-plugins to follow extras instructions, the first make test (make test-no-spark) will fail. Since in the makefile instructions there are no directions to install -r requirements.txt. At least on the kedro-datasets plugin. (Because there is no kedro dependency on the test_requirements.txt that is used on the makefile)
d
Let me ask the team; I don't expect it will work out of the box because of the monorepo setup in
kedro-plugins
, and I don't know if there's been some discussion about how to best handle this. We haven't had as much contribution to
kedro-plugins
before
kedro-datasets
moved in. 🙈
j
Hey @Walber Moreira, so glad you're interested in contributing! 🙂 Thanks for bringing this up, you're right the current setup needs some work, we have an issue currently open to improve it. You're right that one of the things we need to do is
pip install -r requirements.txt
under
install-test-requirements
in the case that
$plugin
is equal to
kedro-datasets
. If you don't want to tackle the setup straight away, it's also totally fine to make a different contribution to
kedro-datasets
, your call 🙂.
w
Thxx! I’m going to be honest that I didn’t checked the open issues, may give it a go before fixing this setup + contributing docs. But I have question: Should kedro-plug-ins really follow the same standard as kedro? I think kedro-docker has some other lint/ci going on