https://kedro.org/ logo
Join Slack
Powered by
anyone around for a quick PR check on the kedro vs...
# questions
p
anyone around for a quick PR check on the kedro vscode plugin? It currently requires hard coding full paths into kedroProjectPath which is bad, much nicer to allow relative to workspaceFolder
👀 1
r
Hi @Pascal Brokmeier, what do you mean by that and is there a PR pending review ?
?
I will request @Jitendra Gundaniya to take a look at this
Thank you for the contribution
p
briefly also looking into how hard monorepo support would be
OK turns out rather easy. I'll update the plugin to auto-detect where the kedro project is and if there are multiple let the user pick which one they want to utilize
n
Autodetect is somewhat there, don't remember exactly how well does it generalized and current options are providing a custom path in case that didn't work
p
custom path requires hard coded absolute path (doesn't work for teams) and only allows 1 project. Autodetect only works at project root
👍🏼 1
j
I'll update the plugin to auto-detect where the kedro project is and if there are multiple let the user pick which one they want to utilize
@Pascal Brokmeier Are you adding this to current PR ?
p
already done
j
Thanks for the contribution. We will review it.
n
Left some comments there
👍 1
p
@Jitendra Gundaniya could you take another look? I addressed most comments https://github.com/kedro-org/vscode-kedro/pull/275
👀 1
@Jitendra Gundaniya or @Sajid Alam can I ask for one last pass? Addressed all FUP comments
👍 1
n
Not sure if there is a release announcement, but I see a new version is released a couple of days ago: https://open-vsx.org/extension/kedro/Kedro
p
2 colleagues mentioned it didn't work for them initially but a mac restart (no idea why) resolved it. I have 0 idea why a mac restart would be needed. But just a heads up
n
Could be VSCode extension caching(?) so it may be just restarting vscode. But if it's full OS restart then I have no idea
p
yeah we tried vscode restart that's why I have 0 idea 😄
also technically cursor not vscode but I doubt that's the culrpit
n
alright, thanks for reporting this so at least we know what to advise.
5 Views
Open in Slack
PreviousNext
Powered by