Hi folks, I don't know if I am making a mistake so...
# questions
f
Hi folks, I don't know if I am making a mistake somewhere but I think there is some issue with the files on PyPi. I have installed 0.19.15 from https://pypi.org/project/kedro/0.19.15/#files. If you download the archive
kedro-0.19.15.tar.gz
and check
KedroSession.create
from
kedro.framework.session
, you will see that the signature has
extra_params
and not
runtime_params
. The source code on the GitHub repository for the tag 0.19.15 is correct though (same for 0.19.14). Please let me know if you see the same thing. 😅
a
cc @Dmitry Sorokin could you verify when you get a chance?
f
From the file on
<http://pypi.org|pypi.org>
Copy code
curl -s -L <https://files.pythonhosted.org/packages/13/8d/a0134b8b5cf0d096ae7372f302e4410c4af11736381a5ee332aafcb4a0b6/kedro-0.19.15.tar.gz> | tar xz && grep extra_params kedro-0.19.15/kedro/framework/session/session.py
I get
Copy code
extra_params: dict[str, Any] | None = None,
            extra_params: Optional dictionary containing extra project parameters
        if extra_params:
            session_data["extra_params"] = extra_params
        extra_params = self.store.get("extra_params")
            extra_params=extra_params,
        extra_params = self.store.get("extra_params")
            runtime_params=extra_params,
        extra_params = self.store.get("extra_params") or {}
            "extra_params": extra_params,
r
It is the same for me and @Dmitry Sorokin can confirm on this. But this release was a bit different (since it was released after 1.0.0 where extra_params was replaced by runtime_params. 0.19.15 was based out of this base branch - https://github.com/kedro-org/kedro/blob/base-0.19.15/kedro/framework/session/session.py#L137 I would like to know if this is causing any issue when you run your pipelines ?
f
I actually checked 19.0.0 on pypi and, if I am not mistaken, the code is the same. The issue is that the documentation and the migration guide are not compatible with the packages.
Did you folks confirm the issue with 19.x version? Should it be skipped?
d
hey Flavien, thank you for raising this. I checked the file on PyPI — it’s aligned with the branch we used for the release: https://github.com/kedro-org/kedro/tree/base-0.19.15 It was an unusual release since we made it after 1.0.0 was already out. That’s likely why the current tag is incorrect — it seems to reuse the same tag as 0.19.14. I think we should consider changing that - I will have a look to possible options. I’ll also take a look at why we switched from
extra_params
to
runtime_params
during that release.
We haven’t changed anything related to the session in the 0.19.15 release, so the 0.19.15 file on PyPI looks the same as the 0.19.14 tag on GitHub in that regard. The only issue is the incorrect 0.19.15 tag on GitHub - I’ll try to fix it and point it to the correct version of the code on the proper branch. If that’s not possible, I’ll remove the tag. Does it clarify your question, Flavien?
So currently 0.19.15 tag points to main branch state after 1.0.0 release
f
OK, I understand now.
OK, I understand now.
I got confused with the content on GitHub then mixed it with the migration towards 1.x that lead me to think that it should have been
runtime_params
on version 0.19.x. Thank you for the clarification. And sorry for the created entropy.
d
no worries, thank you for raising that, we will fix the tag.